feat(material/slider): add customizable thumb dimensions for m2 and m3 #31439
Conversation
mistrykaran91
requested review from
adolgachev and
mmalerba
and removed request for
a team
angular-robot
bot
added
detected: feature
|
I believe you would also need to add some logic to src/material/slider/slider-thumb.ts so that the ripple diameter is calculated based on the slider-thumb-width and slider-thumb-height |
mistrykaran91
force-pushed
the
feat/introduc-token-for-slider-dimensions
branch
from
ac555fa to
dba1885
Compare
Thanks @wagnermaciel, I have created |
mistrykaran91
force-pushed
the
feat/introduc-token-for-slider-dimensions
branch
from
dba1885 to
f8cab36
Compare
| @@ -117,7 +117,8 @@ export class MatSliderVisualThumb implements _MatSliderVisualThumb, AfterViewIni | |||
| return; | |||
| } | |||
|
|
|||
| this._ripple.radius = 24; | |||
| const thumbDiameter = this._hostElement.offsetHeight || 48; | |||
| this._ripple.radius = thumbDiameter / 2; | |||
There was a problem hiding this comment.
We should add a token for this and default to computing this based on the slider thumb width/height (whichever is greater).
There was a problem hiding this comment.
I'm bit new to css things, not sure I got it completely. As, in adding new token for this radius ? Also, do we need to update slider-input.ts too ? Line 778 where ripplePadding is 48px ?
mistrykaran91
force-pushed
the
feat/introduc-token-for-slider-dimensions
branch
from
f8cab36 to
9019a0e
Compare
Fixes #31101